Generally, selling sooner rather than later is recommended. Technology depreciates quickly, and prices tend to decline over time.
Keep an eye on Apple's release cycle. Trade-in values may decrease when newer models are announced. If you plan to upgrade, selling your current MacBook Pro before a new release can maximize your return.